react-native-async-image-animated icon indicating copy to clipboard operation
react-native-async-image-animated copied to clipboard

Published 20 hours ago • verified publisher icon ZXVentures

add resizeMode prop

Open drewdulz opened this issue 6 years ago • 10 comments

drewdulz avatar Jan 23 '19 03:01 drewdulz

i think you can set it type to enum,

here: https://facebook.github.io/react-native/docs/image#resizemode

geminiyellow avatar Jan 23 '19 10:01 geminiyellow

I have no experience with typescript, so i'm not certain this is correct, but I think i've changed the type to enum.

drewdulz avatar Jan 23 '19 22:01 drewdulz

Can we get this PR reviewed?

drewdulz avatar Jan 30 '19 18:01 drewdulz

hi @wmcbain please merge this PR and Close: #5

geminiyellow avatar Jan 31 '19 01:01 geminiyellow

@geminiyellow shouldn't the issue be closed after the code is merged and released?

drewdulz avatar Jan 31 '19 02:01 drewdulz

@drewdulz yep, you can use github Close tag in comment, when your PR is merged, it will auto close issue.

geminiyellow avatar Jan 31 '19 02:01 geminiyellow

oh haha I thought you were asking wmcbain to close the issue manually. That's a pretty cool github feature!

drewdulz avatar Jan 31 '19 02:01 drewdulz

@wmcbain? Can this be merged?

drewdulz avatar Feb 11 '19 17:02 drewdulz

@geminiyellow @drewdulz I unfortunately no longer have write access.

Inquiring about getting ownership transferred. Otherwise will fork.

wmcbain avatar May 24 '19 03:05 wmcbain

woo, sounds no good. thank you @wmcbain

geminiyellow avatar May 24 '19 07:05 geminiyellow