mustangproject icon indicating copy to clipboard operation
mustangproject copied to clipboard

Bundled AssertJ shadows current version

Open florianklumb opened this issue 3 years ago • 6 comments

Hi Jochen,

We're implementing a web app for a German government organization and now have a CR to implement an XRechnung based invoicing. Unfortunately, Mustang seems to be bundled with a certain flavor and version of AssertJ that shadows the version we're using in our project (org.assertj.core.api). How do I notice? For instance, the bundled AssertJ seems to not include assertThatCode.

Have you encountered this problem before? Do you have a hint what we can do?

Thanks

Florian

florianklumb avatar Feb 01 '22 17:02 florianklumb

Hi,

  1. Which version of AssetJ do you use?
  2. how do you refer to Mustang? a) If you are using jars: Apart from http://mustangproject.org/deploy/library-2.4.0.jar there is also a original-library-2.4.0.jar and additionally to validator-2.4.0-shaded.jar there is also a unshaded validator-2.4.0.jar . b) If you are using maven central: There were discussions about dependencies in (#185 and ) #227 before they were able to patch it, my point was (and still is) that fundamentally you should be able to use the unshaded artifacts if you take care about the dependencies yourself, as far as I understood shaded used to be a classifier, i.e. I believe the idea was that you can refer to :shaded for shaded assets and only to for an unshaded version. kind regards Jochen

jstaerk avatar Feb 02 '22 09:02 jstaerk

Hi Jochen,

Thanks for your reply. Unfortunately, shading was disabled again (see my reply in #227). I have to say that I cannot follow what you describe. Can you explain?

Thanks

Florian

florianklumb avatar Feb 02 '22 12:02 florianklumb

Hello,

I have the exact same problem here. Is there a way to get the slim jar from maven-central?

Thanks

Jacques

jarhan-pro avatar Mar 22 '22 14:03 jarhan-pro

Hello,

we also have the same problem here. We would prefer to get a slim version of mustang and handle the dependencies by our selfs, cause we have a very complex structure of sub projects with many other dependencies.

Thanks

Dominik

DFenzl avatar Mar 31 '22 06:03 DFenzl

it's available for download, please feel feel to PR to get it in maven central if that's not already possible with classifiers (has anyone tried that recently?)

jstaerk avatar Apr 26 '22 17:04 jstaerk

Hi, I think the jar in maven central should be the one without all the dependencies and if you want to use the uber jar, you can make it available for download on the mustang website. But you should also have both jar available on maven central with classifier. It was done with the <shadedArtifactAttached>true</shadedArtifactAttached> in the pom but was passed to false in the commit 1675728563f02ca1c15ca6eec1b78dec9a32b5df. With shadedArtifactAttached = true, the main jar will be the one without dependencies and if you want the uber jar, you will have to use the shaded classifier : <dependency> <groupId>org.mustangproject</groupId> <artifactId>library</artifactId> <version>2.0.3</version> <classifier>shaded</classifier> </dependency>

jarhan-pro avatar Apr 28 '22 09:04 jarhan-pro