node-unzipper icon indicating copy to clipboard operation
node-unzipper copied to clipboard

Fix parsing zip64 extra field

Open kinolaev opened this issue 3 years ago • 7 comments

Hello,

fields can be omitted in the zip64 extra field, see https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT, 4.5.3.

Thank you for great work!

kinolaev avatar Jul 08 '20 14:07 kinolaev

@ZJONSSON it would be nice if you can merge this PR. I have tested on node version 12 and fix for me the problem of extracting a file > 4 GB.

mrbabbs avatar Jul 18 '20 18:07 mrbabbs

@ZJONSSON we believe this would fix the FILE_ENDED issue we are seeing as well. Would it be possible to have it looked at? Thanks! Edit: looks like one of the build jobs is failing?

amsoedal avatar Aug 03 '20 21:08 amsoedal

@ZJONSSON - It would be awesome to have this PR merged. We've tested it extensively and running it in production.

theill avatar Mar 28 '21 09:03 theill

Any chance this can get merged soonish? please and ty

mtinnes avatar Aug 03 '21 16:08 mtinnes

@ZJONSSON any chance of merging this in? This would be quite helpful. Please

pgbce avatar Sep 10 '21 15:09 pgbce

@kinolaev Thanks for this. This fixes FILE_ENDED issues I'm having.

@ZJONSSON Please merge this.

anderson-arlen avatar Nov 06 '21 14:11 anderson-arlen

@kinolaev Is this fixed by https://github.com/ZJONSSON/node-unzipper/pull/244 or does it still need to be applied?

yocontra avatar Jun 05 '22 18:06 yocontra