node-unzipper icon indicating copy to clipboard operation
node-unzipper copied to clipboard

DeprecationWarning: Buffer() is deprecated due to security and usability issues.

Open panjiang opened this issue 5 years ago • 4 comments

Usage

await fs
      .createReadStream(srcPath)
      .pipe(unzipper.Extract({ path: targetPath }))
      .promise();

Reason

case by

require('buffer-indexof-polyfill');

found new Buffer in

buffer-indexof-polyfill/index.js:10

value = new Buffer(value);

panjiang avatar Jan 06 '20 09:01 panjiang

@ZJONSSON Can we delete the polyfills for node v0.8? That would fix this issue and improve code size.

soda0289 avatar Jan 15 '20 16:01 soda0289

unzipper was intended to be a drop-in replacement for unzip and be supported on all node versions supported by unzip. However we are now in 2020 and I think we should drop this requirement, do a major bump that allows us to drop polyfills and utilize ES6

ZJONSSON avatar Jan 15 '20 17:01 ZJONSSON

Yes - let's drop support for old node versions

geoynomous avatar Jun 03 '20 12:06 geoynomous

Will this issue be fixed?

kelvindemirandabarros avatar Aug 15 '20 04:08 kelvindemirandabarros