algobot icon indicating copy to clipboard operation
algobot copied to clipboard

[WIP] Refactor trend enum values into class

Open inverse opened this issue 3 years ago • 4 comments

inverse avatar Jul 13 '21 19:07 inverse

This is great, but the only thing is that all strategies that that people may have written will need to be updated after this merges. We may need to need bump up the v slightly and trigger a popup for people to know that their strategies will need to be updated.

ZENALC avatar Jul 14 '21 01:07 ZENALC

A tool to automatically do this would be awesome, but not sure if we can do it easily.

ZENALC avatar Jul 14 '21 01:07 ZENALC

@ZENALC Can you show me where the other strategies that users create are passed in? You mean through them modifying their code locally?

inverse avatar Jul 14 '21 18:07 inverse

Ahh found it - yeah this is def a breaking change if people expect the old const values.

We could always leave this pull request then for when we want to update multiple breaking changes

inverse avatar Jul 14 '21 19:07 inverse