Yet-Another-World-Protector icon indicating copy to clipboard operation
Yet-Another-World-Protector copied to clipboard

bug: mixin incompatibility with Moonrise-Fabric 0.1.0-beta.4+e244c60

Open etil2jz opened this issue 1 year ago • 6 comments

When using Moonrise with YAWP at the same time, I encountered a mixin injection conflict. Please see the crash-report attached.

I'm not sure which project to contact first so I priorly came here 🙂 crash-2024-10-03_10.16.00-server.txt

etil2jz avatar Oct 03 '24 10:10 etil2jz

Thanks for reporting this issue. I’ll take a look at it soon. Best regards

Zordak

Z0rdak avatar Oct 03 '24 10:10 Z0rdak

Hi again.

As far as I know, there is nothing I could do in this case.

Moonrise is very invasive while optimizing performance there. It does completely overwrite a specific method, which YAWP only injects a little bit of code into to check for the explosion flags.

Unless there is a possibility using mixins to resolve this I fear that is something I can not fix.

What I can say from Moonrise Github Issue Tracker, there a couple of Incompatability Issues with other mods, some with the same Mixin Issue.

Z0rdak avatar Oct 03 '24 19:10 Z0rdak

Moonrise 0.1.0 beta 5 includes an event for explosions. This should allow fixing the conflict without a Mixin to Moonrise. When Moonrise is present you can skip loading the conflicting Mixin with an IMixinConfigPlugin, and instead register a listener for the event. https://github.com/Tuinity/Moonrise/pull/52 Currently, Modrinth Maven is kind of bugged with file names and won't work for Moonrise, but Curse Maven should work.

jpenilla avatar Oct 15 '24 02:10 jpenilla

@Z0rdak Can you look into it? 🙏

etil2jz avatar Oct 19 '24 09:10 etil2jz

Hey there.

Today I learned that something like a IMixinConfigPlugin exists. Thats GREAT! I was looking for something like this to dynamically (config based) load mixins! Thanks @jpenilla for pointing this out to me.

@etil2jz I need to finish some other issues first, but I'll look into it.

Z0rdak avatar Oct 21 '24 09:10 Z0rdak

Just a little update:

I actually got another mod incompat which needs a similar treatment and recently had someone help me with a system for this.

So I'll take a look into addin this compat, too.

Z0rdak avatar Feb 19 '25 19:02 Z0rdak