in develop no serverEntryId in response

[mschering]

When using a diffbackend it no longer responds with the ServerEntryId when adding new items:

26/05/2025 11:02:50 [ 273] [WBXML] [admin] O 26/05/2025 11:02:50 [ 273] [WBXML] [admin] O 26/05/2025 11:02:50 [ 273] [WBXML] [admin] O 6212 26/05/2025 11:02:50 [ 273] [WBXML] [admin] O

This part is missing:

26/05/2025 11:02:50 [ 273] [WBXML] [admin] O <ServerEntryId> 26/05/2025 11:02:50 [ 273] [WBXML] [admin] O 236 26/05/2025 11:02:50 [ 273] [WBXML] [admin] O </ServerEntryId>

There seems to be a breaking change in the IImportChanges interface:

https://github.com/Z-Hub/Z-Push/blob/27af6224012d639375ba26701564459a45ad0aab/src/lib/interface/iimportchanges.php#L57

It should return a string ID here but the kopano backend returns an object:

https://github.com/Z-Hub/Z-Push/blob/af25a2169a50d6e05a5916d1e8b2b6cd17011c98/src/backend/kopano/importer.php#L397

Is the diffbackend broken?

Best regards, Merijn

[mschering]

This commit seems to be related:

https://github.com/Z-Hub/Z-Push/commit/22b3bf9c40ff54a213904281702c82305748239c

[matidau]

This isn't in 2.7.5 but in the develop branch.

Continuing to work on these changes to support AS16 but haven't released it to develop branch yet.

[mschering]

Ah ok sorry.

[matidau]

No problems. Was hoping to have this completed sooner.

[mschering]

The commit above seems to fix it.