RollingText icon indicating copy to clipboard operation
RollingText copied to clipboard

Add small improvements

Open DeFuex opened this issue 5 years ago • 2 comments

  • Does add android ktx to use e.g: withStyledAttributes.
  • uses @JvmOverloads to hide all constructor calls and uses kotlins init {} function instead.
  • enable jvm 1.8 bytecode compilation target for withStyledAttributes function.

DeFuex avatar Oct 01 '20 00:10 DeFuex

Thanks for your contribution! “Uses @JvmOverloads to hide all constructor calls and uses kotlins init {} function instead.” looks good. However, I hesitate to use AndroidX and target jvm1.8, which might increase the threshold for users. For now, There are still some old fat project using "support library" instead of "AndroidX". A library should be able to adapt to as many development environments as possible.

YvesCheung avatar Oct 10 '20 10:10 YvesCheung

Hi, no problem, i will change it to only use the Overload anmotation then.

DeFuex avatar Oct 10 '20 10:10 DeFuex