apps icon indicating copy to clipboard operation
apps copied to clipboard

[enh] ensure that all apps in lists is ok

Open kay0u opened this issue 5 years ago • 7 comments

This script check the url, the branch an the revision for all apps in lists.

kay0u avatar Feb 21 '19 19:02 kay0u

@alexAubin @Psycojoker do you have any opinion on that ?

maniackcrudelis avatar Apr 02 '19 10:04 maniackcrudelis

Hmmm in fact I'm wondering how much of a good idea it is to run ~200 git clones in Travis ...

Github ain't gonna like that ... at least not without a token ... but even with a token it probably takes hell of a time :/

I dunno if there could be some trick in travis to only check apps affected by the commits ?

I can get modified lines in the PR (like a diff between the PR and master), retrieve the json part we want to check, and check it? It will be ugly but I can do it :-)

kay0u avatar Apr 02 '19 12:04 kay0u

I can get modified lines in the PR (like a diff between the PR and master), retrieve the json part we want to check, and check it? It will be ugly but I can do it :-)

Well yup, not sure if we can build a reliable way but anyway I doubt that we really want to trigger 250+ git clones each time we do a PR / commit here :P

alexAubin avatar Apr 02 '19 13:04 alexAubin

What the hell, this is from more than 1 year ago !? I was convinced this was for less than 6 months ago x_x

Anyway, @kay0u : I know we love travis but what would you think about having our own cache of all the git clones (with --shallow-commit-whatever), and running the tests on our infra every day or X hours ? Not only is this less crazy in terms of having hundreds of git clone every commit (or weird engineering to test only the diff) but we could also :

alexAubin avatar Apr 04 '20 12:04 alexAubin

Meh 1 year already :/

I guess the list builder will fail if the sha1 is not valid for the repo? It might be enough.

use it for analysis of helper usage or related stuff (had to do that kind of stuff a lot when working on helpers / package check) ...

The app CI is here for that right?

kay0u avatar Apr 04 '20 16:04 kay0u

The app CI is here for that right?

I was meaning thing like "finding out how many apps use helper X", or anything that involves to "grep -r" all apps repo ... or more recently running a new package_linter on all repo to find about all nginx path traversal issue, etc ...

Github sort of allow searches, but it's pretty limited

Anyway, I'm working on a rework of the list builder based on this idea right now ..

alexAubin avatar Apr 04 '20 16:04 alexAubin

BTW. Travis is going to close support for opensouce projects, isn't it?!?

jedie avatar Apr 24 '21 06:04 jedie

We can close this PR I guess? Please reopen if I'm wrong

ericgaspar avatar Oct 16 '22 18:10 ericgaspar