wordpress_ynh icon indicating copy to clipboard operation
wordpress_ynh copied to clipboard

Published 20 hours ago • verified publisher icon YunoHost-Apps

add allow_email parameter

Open lapineige opened this issue 1 year ago • 8 comments

It's needed for signed emails.

PR Status

  • [x] Code finished and ready to be reviewed/tested
  • [ ] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

lapineige avatar Dec 31 '23 18:12 lapineige

!testme

lapineige avatar Dec 31 '23 18:12 lapineige

Fingers crossed! Test Badge

yunohost-bot avatar Dec 31 '23 18:12 yunohost-bot

cf https://github.com/YunoHost-Apps/wordpress_ynh/pull/230#discussion_r1412851429

alexAubin avatar Dec 31 '23 18:12 alexAubin

It's needed for some extensions that send email, so let's keep it ?

lapineige avatar Dec 31 '23 18:12 lapineige

To me that just gives the false impression that the app integrates properly with email, which it doesnt if this ain't actually used ... Or if we can't configure it automatically, we should at least properly document it how to manually configure it in ADMIN.md maybe ...

alexAubin avatar Dec 31 '23 18:12 alexAubin

Or if we can't configure it automatically, we should at least properly document it how to manually configure it in ADMIN.md maybe ...

Well then this is the TODO here 🙂

lapineige avatar Dec 31 '23 18:12 lapineige

the password generated for the mail must be displayed somehow...

ericgaspar avatar Nov 20 '24 19:11 ericgaspar

the password generated for the mail must be displayed somehow...

In ADMIN.md maybe ?

lapineige avatar Jan 03 '25 09:01 lapineige