wordpress_ynh icon indicating copy to clipboard operation
wordpress_ynh copied to clipboard

Published 20 hours ago • verified publisher icon YunoHost-Apps

Allow specifying PHP version #223

Open fflorent opened this issue 2 years ago • 8 comments
trafficstars

Problem

  • Some plugins are not compatible yet with PHP 8.2 and make wordpress crash

Solution

  • Allow the user specifying the PHP version

PR Status

  • [x] Code finished and ready to be reviewed/tested
  • [x] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

closes #223

fflorent avatar Oct 07 '23 19:10 fflorent

!testme

fflorent avatar Oct 11 '23 17:10 fflorent

May the CI gods be with you! Test Badge

yunohost-bot avatar Oct 11 '23 17:10 yunohost-bot

!testme

fflorent avatar Oct 11 '23 21:10 fflorent

:stuck_out_tongue_winking_eye: Test Badge

yunohost-bot avatar Oct 11 '23 21:10 yunohost-bot

I think that we shouldn't ask PHP version when installing Wordpress. If we need to change the PHP version, I think the config panel is the good place for this setting.

Tagadda avatar Oct 11 '23 22:10 Tagadda

I think we need to somehow propose the PHP version, as some plugins cannot be removed easily and still need PHP version < 8.1. Unless we are OK with downgrading the PHP version (however not sure if that's a good idea).

I like the proposal of proposing the option through the config panel, however I am not sure how simple it is to implement that (having to move the pool configuration file to a PHP version to another, reload or restart the previous and the new FPM service, removing the old dependencies and reinstalling the dependencies according to the new version, etc.).

fflorent avatar Oct 12 '23 06:10 fflorent

my_weppapp_ynh does this already o/ https://github.com/YunoHost-Apps/my_webapp_ynh/blob/master/config_panel.toml#L24-L28 https://github.com/YunoHost-Apps/my_webapp_ynh/blob/master/scripts/config#L113-L136

Tagadda avatar Oct 12 '23 09:10 Tagadda

Thanks for the hint @Tagadda!

App dependencies do not seem to be all reinstalled: https://github.com/YunoHost-Apps/my_webapp_ynh/issues/131

I opened this PR, though I wonder if something simpler could be done: https://github.com/YunoHost-Apps/my_webapp_ynh/pull/130/files

I guess similar issue would exist for Wordpress if the php version could be changed through the config panel.

fflorent avatar Oct 16 '23 08:10 fflorent