nextcloud_ynh Add notify push option

Add notify push option

Open kay0u opened this issue 3 years ago • 18 comments

Solution

Nextcloud comes with a "10x better performance" announcement which depends on an app, this PR aims to install it

PR Status

It's ready to be tested, but I still need to modify the service with the correct architecture.

To make it works on my side, I had to add in the /etc/hosts file (not tested on non root install of nextcloud):

127.0.0.1       my.nextcloud.domain.tld
::1                  my.nextcloud.domain.tld

[ ] Code finished and ready to be reviewed/tested
[ ] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

Jun 08 '21 18:06 kay0u

The more I implement it, the more I don't want it to see that PR merged.

There are so many ways to make this notify_push app not work.

Jun 09 '21 16:06 kay0u

!testme

Jun 09 '21 16:06 kay0u

:stuck_out_tongue_winking_eye:

Jun 09 '21 16:06 yunohost-bot

!testme

Jun 10 '21 08:06 kay0u

:v:

Jun 10 '21 08:06 yunohost-bot

!testme

Jun 10 '21 10:06 kay0u

:rocket:

Jun 10 '21 10:06 yunohost-bot

Hello @kay0u Thanks a lot for what you are doing here !!

The more I implement it, the more I don't want it to see that PR merged.

There are so many ways to make this notify_push app not work.

Do you think this PR will once be merged or is it better to setup notify-push by myself ? Thanks 😇

Nov 02 '21 10:11 Thovi98

Hello!

If you are comfortable with the command line, I think you can make the changes by hand.

I'd like the opinion of others app's group on it, because Nextcloud is one of the most used apps in YNH, it's already horrible to maintain, and there are errors with each new version, so any new features added to this package will be yet another part that can be an issue when upgrading.

Nov 05 '21 11:11 kay0u

Thanks for your answer !

I'd like the opinion of others app's group on it, because Nextcloud is one of the most used apps in YNH, it's already horrible to maintain, and there are errors with each new version, so any new features added to this package will be yet another part that can be an issue when upgrading.

I am probably not the right person to answer this given my lack of knowledge, but my two cents :

notify_push is more a "nice to have" than a "must have" : Nextcloud already perfectly works without this app.
It becomes more useful when there are a lot of Nextcloud users : generally, maintainers of big instances can use the command line.

So, altough it’s not ideal for a Yunohost package, I would rather go to a documentation which explains how to install notify_push with the command line. I think it’s better to have a robust initial package that has faster updates than something complex...

But to help users as much as possible, we can pave the way by already prepare notify_push with the corresponding lines, but commented, in nginx, /etc/hosts, config.php, …

Nov 09 '21 12:11 Thovi98

FYI, about documenting an install process compatible with YNH (in french) : https://hackriculture.fr/nextcloud-synchronisation-de-fichiers-plus-performante-avec-notify_push-hpb.html