nextcloud_ynh icon indicating copy to clipboard operation
nextcloud_ynh copied to clipboard

/etc/cron.d/nextcloud may not exists and this breaks backup

Open alexAubin opened this issue 5 years ago • 7 comments

c.f. https://paste.yunohost.org/raw/bipinopaye

2019-02-24 00:13:02,505: DEBUG - 1691 + ynh_backup /etc/cron.d/nextcloud
[...]
2019-02-24 00:13:02,495: WARNING - 1687 Source path '/etc/cron.d/nextcloud' does not exist

alexAubin avatar Feb 24 '19 17:02 alexAubin

Super weird because it seems to be always created in install and upgrade...

JimboJoe avatar Feb 24 '19 18:02 JimboJoe

Meh yea I was thinking about an old instance but if it was added during the upgrade at the time it was introduced, shouldnt be any issue :/

alexAubin avatar Feb 24 '19 18:02 alexAubin

It happened again here... We could put up a dirty fix in the backup script, but that's not satisfying... Any other opinion on this @YunoHost-Apps/apps-group ? EDIT: Oops, that latter problem is related to logrotate config, not cron...

JimboJoe avatar Mar 04 '19 17:03 JimboJoe

I recently introduce an option to ynh_backup for that kind of error https://github.com/YunoHost/yunohost/blob/stretch-stable/data/helpers.d/filesystem#L19

maniackcrudelis avatar Mar 04 '19 17:03 maniackcrudelis

Yes, but what are relevant use cases? Here there is a problem somewhere that makes that file disappear... is there any other potential problem that could be hidden behind this...?

JimboJoe avatar Mar 04 '19 18:03 JimboJoe

Indeed, there's probably something else behind, or the user has removed the file himself. But in any case, does that error should prevent an upgrade of the app ?

maniackcrudelis avatar Mar 04 '19 18:03 maniackcrudelis

Similar issue here : https://forum.yunohost.org/t/probleme-mise-a-jour-nexcloud-depuis-passage-sous-strech/7501

with logrotate file this time

2019-03-27 17:01:01,320: DEBUG - 12656 + ynh_backup /etc/logrotate.d/nextcloud
2019-03-27 17:01:01,321: WARNING - 12657 Source path '/etc/logrotate.d/nextcloud' does not exist
[...]
2019-03-27 17:01:01,324: WARNING - 12659   nextcloud's script has encountered an error. Its execution was cancelled.

alexAubin avatar Mar 27 '19 17:03 alexAubin