cryptpad_ynh Testing

Problem

no sandbox domain

Solution

implement sandbox domain

PR Status

[x] Code finished and ready to be reviewed/tested
[x] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

Oct 14 '22 21:10 Ddataa

!gogogadgetoci

Oct 14 '22 21:10 Ddataa

!testme

Oct 14 '22 21:10 ericgaspar

Fingers crossed!

Oct 14 '22 21:10 yunohost-bot

!gogogadgetoci

Oct 18 '22 14:10 Ddataa

!testme

Oct 18 '22 14:10 ericgaspar

Fingers crossed!

Oct 18 '22 14:10 yunohost-bot

!gogogadgetoci

Oct 18 '22 15:10 Ddataa

!testme

Oct 18 '22 15:10 ericgaspar

I like this semi-automatic process :)

Oct 18 '22 15:10 ericgaspar

!testme

Oct 18 '22 15:10 ericgaspar

:carousel_horse:

Oct 18 '22 15:10 yunohost-bot

I actually restarted one previous job it in the meantime...:/

Oct 18 '22 16:10 Ddataa

more tests more fun :p

Oct 18 '22 16:10 Ddataa

I actually restarted one previous job it in the meantime...:/

Ah! I thought I had lost my mojo 😅

Oct 18 '22 16:10 ericgaspar

I trust you still have mojo.

I want this those tests to pass green...

Oct 18 '22 16:10 Ddataa

Damn !!

What is this kind of error ?

6012 INFO [+++.................] > Installing Cryptpad Sandboxing App if needed... [00h00m,01s]
14551 WARNING Pick a valid value for argument 'domain': 'sandbox-sub.domain.tld' is not among the available choices (domain.tld, sub.domain.tld)

Oct 18 '22 16:10 Ddataa

maybe the sandboxing app needs to be pass the tests first since this one install it, no ?

Oct 18 '22 16:10 Ddataa

By the power of systemd, I invoke The Great App CI to test this Pull Request!

Oct 20 '22 13:10 Ddataa

:stuck_out_tongue_winking_eye:

Oct 20 '22 13:10 yunohost-bot

By the power of systemd, I invoke The Great App CI to test this Pull Request!

Oct 20 '22 19:10 Ddataa

May the CI gods be with you!

Oct 20 '22 19:10 yunohost-bot

By the power of systemd, I invoke The Great App CI to test this Pull Request!

Oct 21 '22 15:10 Ddataa

:v:

Oct 21 '22 15:10 yunohost-bot

the issue seems to be that /var/www/$app doesn't have group owner as www-data...I did add it in install script then forgot about it and so forgot to add it in restore / upgrade script. I thought that was quite standard and didnt think of having to do it manually...

Oct 21 '22 17:10 Ddataa

I am testing to install it to my server, and it seems to not be able to creat the sandbox domain. Here is the logs: https://paste.yunohost.org/raw/inotimezoh

Oct 21 '22 18:10 ericgaspar

yes it is normal, I have changed method on limezy advice. Now it is on the admin to create both domain manually before install and also install correct LE certificate (the script check for that as for now).

I still have to update the readme to make it clear unless we/I go back to initial plan which was to have auto creation of the sandbox domain.... I kind of like the idea of having the sandbox created automatically during install but then LE certificate wont be anyway...

What do you think @ericgaspar ?

Oct 21 '22 20:10 Ddataa

I was expecting to be asked during install to point out the sandboxing domain.

but yes, ideally if the process could be transparent it will be great.

Oct 21 '22 21:10 ericgaspar

By the power of systemd, I invoke The Great App CI to test this Pull Request!

Oct 22 '22 14:10 Ddataa

:rocket:

Oct 22 '22 14:10 yunohost-bot

By the power of systemd, I invoke The Great App CI to test this Pull Request!

Oct 22 '22 16:10 Ddataa

cryptpad_ynh cryptpad_ynh copied to clipboard

Testing

Problem

Solution

PR Status

Automatic tests

cryptpad_ynh
cryptpad_ynh copied to clipboard