YPImagePicker If onlySquare is enabled, execute fitImage on display.

If onlySquare is enabled, execute fitImage on display.

Open hanawat opened this issue 2 years ago • 4 comments

#776

To fix above issue.

If onlySquare is enabled when displaying an Asset, call fitImage to crop it to a square.

You can see how it works in the sample apps in the feature/demo branch. https://github.com/hanawat/YPImagePicker/tree/feature/demo

Before	After

Dec 15 '22 12:12 hanawat

With this fix, the selected image view can't be moved up when scrolling. Can you take a look?

Feb 15 '23 22:02 ramboli1986

@keremcesme Thank you for your review. Videos in the library also used fitImage.

Feb 17 '23 07:02 hanawat

@ramboli1986 Did you run that in the sample app? I checked and it works fine in the sample app.

Feb 17 '23 07:02 hanawat

@ramboli1986 Did you run that in the sample app? I checked and it works fine in the sample app.

Nvm, I can't repo it any more. Thanks for the fix.

Feb 22 '23 01:02 ramboli1986