YPImagePicker icon indicating copy to clipboard operation
YPImagePicker copied to clipboard

[BUG] Thumbnail can be selected outside of trim

Open Ludotrico opened this issue 4 years ago • 8 comments

When trimming a video and then selecting a thumbnail, the thumbnail chooser view is unaware of the trim and allows you to choose a frame outside of the trim.

This is not good @heitara @NikKovIos

Ludotrico avatar Jan 25 '21 08:01 Ludotrico

@Ludotrico could you record a short video that illustrates this bug?

heitara avatar Jan 25 '21 08:01 heitara

https://youtu.be/f7JQYdOIC5g Did you get a chance to look at this? @heitara @NikKovIos @s4cha

Ludotrico avatar Jan 25 '21 20:01 Ludotrico

It has been a few months, any signs of life? @heitara @NikKovIos @s4cha

Ludotrico avatar Mar 17 '21 03:03 Ludotrico

Unfortunately this functional depends on https://github.com/HHK1/PryntTrimmerView/issues pod.

NikKovIos avatar Mar 18 '21 19:03 NikKovIos

We with @s4cha decided to insert PryntTrimmerView code into the project and remove the cocoapods dependence for this. It will help to give the possibility to fix the bug.

NikKovIos avatar Mar 19 '21 11:03 NikKovIos

That's a good start, thank you @NikKovIos

Ludotrico avatar Mar 19 '21 17:03 Ludotrico

Hi @NikKovIos Any update on this?

gupta1111-eng avatar Jun 02 '21 18:06 gupta1111-eng

I've been granted an access to push and publish updates for TrimmerView but don't have time to fix that. However, you can create an issue in https://github.com/HHK1/PryntTrimmerView/issues to make the changes faster.

NikKovIos avatar Jun 04 '21 23:06 NikKovIos