YPImagePicker icon indicating copy to clipboard operation
YPImagePicker copied to clipboard

[Bug] Properties bottomMenuItemSelectedTextColour and bottomMenuItemUnSelectedTextColour are not used

Open Ricardo1980 opened this issue 5 years ago • 0 comments

Describe the bug bottomMenuItemSelectedTextColour and bottomMenuItemUnSelectedTextColour are completely ignored by the app. It does not matter what color we use. I also see that in the source code they only appear once.

bottomMenuItemSelectedTextColour https://github.com/Yummypets/YPImagePicker/blob/5f90725766db9d6a9437b82ee63658042eaf67d1/Source/Configuration/YPImagePickerConfiguration.swift#L107

bottomMenuItemUnSelectedTextColour https://github.com/Yummypets/YPImagePicker/blob/5f90725766db9d6a9437b82ee63658042eaf67d1/Source/Configuration/YPImagePickerConfiguration.swift#L110

To Reproduce Modify the example app. Add something like:

config.bottomMenuItemSelectedTextColour = .red
config.bottomMenuItemUnSelectedTextColour = .green

See that the bottom buttons don't change.

Expected behavior Bottom buttons should have another color.

Screenshots Not necessary.

Environment (please complete the following information): iPhone X. Xcode 11 Library build 4.3.1

Installation Type Pods

Additional context I see the same is inside YPColors, so, I guess only those 2 properties need to be removed.

Ricardo1980 avatar Nov 21 '20 20:11 Ricardo1980