city-lights-ui-atom icon indicating copy to clipboard operation
city-lights-ui-atom copied to clipboard

Published 20 hours ago • verified publisher icon Yummygum

Use indirect reference on tree view tab

Open rschiang opened this issue 6 years ago • 3 comments

This PR fixes #48 as it references to tree view tab indirectly (finds the parent element of .tab[data-type='TreeView']) instead of hiding the first one.

Works for me!

rschiang avatar Oct 13 '18 18:10 rschiang

I added another commit as I realized Atom will not put tree view into DOM hierarchy if you don't have projects opened. Dynamically observe pane item additions (and fix the tree view tab accordingly) solves the problem.

rschiang avatar Oct 13 '18 18:10 rschiang

Thanks for the PR !

I'll take a look at this asap! for now it lgtm but have to test😉

noudadrichem avatar Oct 16 '18 09:10 noudadrichem

@noudadrichem Hi Noud, any assistance I could provide to make things smoother? :)

rschiang avatar Mar 06 '19 12:03 rschiang