city-lights-syntax-vsc icon indicating copy to clipboard operation
city-lights-syntax-vsc copied to clipboard

Published 20 hours ago • verified publisher icon Yummygum

Latest version of VSCode breaks City Lights for Babel Language

Open mfix22 opened this issue 5 years ago • 12 comments

Everything just looks gray and blue now 🤷‍♂

mfix22 avatar Jan 15 '20 19:01 mfix22

What is the 'latest version' ? Everything looks fine on my machine.

noudadrichem avatar Jan 15 '20 19:01 noudadrichem

I'll close this until I can investigate further. Sorry about the poorly formed issue — was in too big of a rush!

mfix22 avatar Jan 16 '20 05:01 mfix22

Screen Shot 2020-01-23 at 2 35 42 PM

Maybe I am wrong, but I thought components are supposed to be rendered as not gray

mfix22 avatar Jan 23 '20 22:01 mfix22

This is true! Can you provide some more details on versions etc.? I'm still not facing this issue. So a bit more context would be great for me to investigate further.

Thank you in advance!

noudadrichem avatar Jan 27 '20 08:01 noudadrichem

Code version: 1.41.1 City lights version: 1.1.5 Babel Javascript (by Michael McDermott) version: 0.0.25

Using macOS, Mojave, 10.14.6

Let me know if there is anything else that would help!

mfix22 avatar Jan 28 '20 17:01 mfix22

I can reproduce the same issue, comparing the generated markup/html with the default vscode editor and city lights, I see that the default theme wraps < and the component name in two different span

image

While city lights wraps both in the same: image

FezVrasta avatar Mar 05 '20 15:03 FezVrasta

Hi @mfix22

I think this is due too new updates on how colors are processed... I'm looking into it at the moment. But for now you can disable semantic highlighting and all should work as the old!

Add "editor.semanticHighlighting.enabled": false to your settings.json

noudadrichem avatar Mar 14 '20 14:03 noudadrichem

Hi @FezVrasta,

I'm not sure what you want me to do with a HTML screenshots of VSCode. We don't change any HTML on purpose as the colors are 'just' processed from a JSON file.

noudadrichem avatar Mar 14 '20 14:03 noudadrichem

@noudadrichem I don't know, I just noticed this difference and reported back, I have no knowledge about this so I was just trying to be useful.

To be clear, those screenshots are from the vscode dev tools, it's not my own code obviously, it's just the markup generated by vscode to highlight the same segment of code with the two themes.

FezVrasta avatar Mar 14 '20 18:03 FezVrasta

editor.semanticHighlighting.enabled is already set to false on my environment anyways.

FezVrasta avatar Mar 14 '20 18:03 FezVrasta

Add "editor.semanticHighlighting.enabled": false to your settings.json

@noudadrichem thank you! I will give this a shot 👍

mfix22 avatar Mar 14 '20 23:03 mfix22

I am still noticing the issue. The one difference between the two computers I have this theme installed on is that the one using the Babel JavaScript plugin by Michael McDermott is showing the issue above, and the other one isn't, regardless of my editor.semanticHighlighting.enabled setting.

mfix22 avatar Mar 16 '20 16:03 mfix22