Victoria
Victoria copied to clipboard
Yucked
Error checks for JavaBinaryWriter and tweaks to the TrackEncoder
After further testing of the TrackEncoder, I noticed that some error checks and tweaking were needed.
Meanwhile, I also caught another problem caused by that change that I made to the TrackDecoder to also read the "source" and "position" properties, which happens on "local" and "http" tracks, because in those cases Lavalink attaches a "probe" property (from what I can understand it's generally just the type of the track i.e mp3, ogg, etc...) between the "source" and "position" properties, so I "fixed" it by just ignoring it with a call to ReadString
And by "fixing" I also broke the other kinds of tracks, so I added a check to the "source", I'm really sorry should have noticed it before I pushed that commit, if you want you can close this and I'll open a new PR, to avoid these unnecessary commits.