yubioath-flutter icon indicating copy to clipboard operation
yubioath-flutter copied to clipboard

Regression in accessibility (can't use keyboard)

Open elboletaire opened this issue 4 years ago • 7 comments

  • Yubico Authenticator version: 5.0.3
  • Operating system and version: Windows 10 Pro 1909, at least.
  • YubiKey model and version: Doesn't matter.
  • Bug description summary: Previous version of yubioath allowed to only use the keyboard to select keys. Now isn't possible.

Steps to reproduce

  • Open Yubioath.
  • Use the arrow keys to move between different results.
  • Try to activate one using the keyboard (I've tried space & intro and combinations using shift and control).

Note that you'll be able to select among results if you haven't filtered, but then you won't be able to enable them.

But, if you filter results, you can't even move around in the results list:

  • Use the filter bar to start filtering a 2fa
  • Try to use the keyboard (with tab &/or arrows) and you'll see the visible options won't be selected or hovered, like they do when not filtering.

Expected result

Being able to select the visible codes using the keyboard, like it was possible in version 4.

Actual results

After filtering, can't select any results (or can't see the way).

elboletaire avatar Apr 14 '20 17:04 elboletaire

Thanks for reporting, could you please provide more information about your setup though as I can't reproduce this.

Also note that if you press tab or left/right arrows you will start by moving in the menu bar, but down arrow should take you right to the filtered list. Also the top filtered result is already highlighted so pressing return directly is enough to copy it.

braathen avatar Apr 14 '20 18:04 braathen

Mmmh... it's a fresh install on a new computer, that's why I realized.. because I'm still using version 4 in another computer.

Now I'm trying it and seems that it works sometimes. If I just open yubico authenticator, I cannot enable a code only by using the keyboard. It does not show the "Touch your yubikey" text, and doesn't work at all.

After double-clicking on a code, then the other subsequent keyboard shortcuts work as expected. I can then copy a code by just moving around with the keyboard as expected.

So seems to be only when opening the app for the first time which, in my case, it's every time I do use yubioath, due to #297

Edit: nope, this should be checked in more depth. There are other use cases where it starts failing again. I'm still not sure how to reproduce them, but I've had the app opened for some minutes now and the intro behavior happened again.

elboletaire avatar Apr 15 '20 00:04 elboletaire

ok, thanks for checking again, we'll try to look into it. what operating system and version are you using?

braathen avatar Apr 15 '20 05:04 braathen

Windows 10 Pro 1909

imatge

elboletaire avatar Apr 15 '20 10:04 elboletaire

I think we've found the issue and we'll fix this in the next update. Meanwhile Ctrl-C to initiate "touch your Yubikey" seems to work while waiting for the fix. Thank you for finding this!

braathen avatar Apr 15 '20 12:04 braathen

Can't try the ctrl+c behavior (my yubi is wet right now 😅), but I'll give it a try asap and I'm glad you found the actual issue 😃

elboletaire avatar Apr 15 '20 13:04 elboletaire

Confirmed that ctrl + c works, so I'll use that as a workaround until a fix is released. Thanks!

elboletaire avatar Apr 15 '20 14:04 elboletaire

Yubico Authenticator 6.0 has now been released and uses a new codebase. As such, this issue has been marked with the legacy label, and will be automatically closed in 7 days. If this issue is still relevant to Yubico Authenticator 6, please comment on the issue saying so, and it will be kept open (or be re-opened). Sorry for the inconvenience!

dainnilsson avatar Nov 16 '22 10:11 dainnilsson