yubico-piv-tool icon indicating copy to clipboard operation
yubico-piv-tool copied to clipboard

BUG: `2.4.0/2.4.1` - macOS `pkg` | `package receipt` is not applied properly to final release

Open radsec opened this issue 7 months ago • 4 comments

Please re-release the macOS universal packages to contain a package version applied to the resulting binaries/application.

See - bug - 2.4.0 - yubico-piv-tool-2.4.0-mac-universal.pkg image

Expected -2.4.0 - Reviewed the github CI/workflows and the arm package compiles correctly - https://github.com/Yubico/yubico-piv-tool/actions/runs/7051164256 image

Correctly working version - 2.3.1 - yubico-piv-tool-2.3.1-mac-universal.pkg image

radsec avatar Dec 06 '23 04:12 radsec

Thank you for the notification. Seems like some processes have changed from one version to another. Our release routines are now updated to make sure the version number appears correctly

aveenismail avatar Dec 06 '23 13:12 aveenismail

Are you able to re-release the package on the public page?

where the links are:https://developers.yubico.com/yubico-piv-tool/Releases/.

I just re-downloaded it and the internal com.yubico.yubico-piv-tool version is still 0.0 and showing incorrectly.

Running the Github actions in the repo locally produce a binary with the correct package versions/receipts.

radsec avatar Dec 07 '23 00:12 radsec

There is now a new release 2.4.2. The version number issue should be fixed there. Please let us know if the problem still persists.

aveenismail avatar Dec 07 '23 22:12 aveenismail

Version 2.4.2 has the same issue, unfortunately. If you expand the latest pkg:

pkgutil --expand-full yubico-piv-tool-2.4.2-mac-universal.pkg pkgfiles

You'll see pkgfiles/Distribution now contains the correct version, but pkgs/yubico-piv-tool.pkg/PackageInfo still contains version="0", causing the receipt to still have version 0:

image

korylprince avatar Dec 11 '23 16:12 korylprince

Fixed in 2.5.1.

Thanks for getting this resolved.

radsec avatar Mar 30 '24 17:03 radsec