java-webauthn-server icon indicating copy to clipboard operation
java-webauthn-server copied to clipboard

Added credProps.authenticatorDisplayName

Open fdennis opened this issue 1 year ago • 2 comments

fdennis avatar Jun 13 '24 12:06 fdennis

Test Results

2 218 tests  +12   2 210 :white_check_mark: +12   1m 31s :stopwatch: +33s    45 suites ± 0       8 :zzz: ± 0     45 files   ± 0       0 :x: ± 0 

Results for commit a1a3e2f4. ± Comparison against base commit 563e5c34.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jun 13 '24 12:06 github-actions[bot]

When will this be merged? 1Password is sending this field and it's failing because of FAIL_ON_UNKNOWN_PROPERTIES

warchildmd avatar Jun 20 '24 06:06 warchildmd

@warchildmd : Same here, i'm interested about a merge 👍

JDussaussois avatar Jul 09 '24 06:07 JDussaussois

@warchildmd Which version of webauthn-server-core are you using? That issue should have been fixed in release 2.5.2.

emlun avatar Jul 09 '24 12:07 emlun

@emlun : I'm actually using release 2.5.2 and the error is still here : UnrecognizedPropertyException: Unrecognized field "authenticatorDisplayName"

JDussaussois avatar Jul 09 '24 12:07 JDussaussois

Ok, we can fast track a bug fix for that then. Could you please open a new issue and include the full stack trace of the exception?

emlun avatar Jul 09 '24 12:07 emlun

My bad, after a deep check, i'm actually using 2.5.1 in my deployed env, i'll update to 2.5.2 and check, thanks for the feedback

JDussaussois avatar Jul 09 '24 12:07 JDussaussois

@JDussaussois Did the upgrade fix your problem?

emlun avatar Jul 11 '24 11:07 emlun