Ihor Dutchak comments

Results 428 comments of


                                            Ihor Dutchak

Added libusb_get_device_string() which works with a closed device

@seanm please mark your comments as resolved if they are, so we can see if this is ready to be merged. Thanks.

Added libusb_get_device_string() which works with a closed device

At this point we wait for the maintainers to find time the finish (perform) their review and approve it nothing comes up. Ping: @tormodvolden, @hjelmn

Added libusb_get_device_string() which works with a closed device

Before we merge this, I have one more reqiest: shorten the commit message. Only keep "what was done", specially remove everything after `References:`, including any mention of users. All of...

xusb: Define proper exit status

I'd also change the `test_device` to return `0`/`1` (instead of `-1`), or even `EXIT_SUCCESS`/`EXIT_FAILURE` named constants. Negative exit code usually means exit by interruption.

xusb: Define proper exit status

That sounds even better

Implement parsing of MS OS 1.0 descriptors

Lets start with fixing the CI

Warning in the last 2 releases of libusb [1.0.27 and 1.0.28] .

I assume you have logging disabled?

Warning in the last 2 releases of libusb [1.0.27 and 1.0.28] .

Partially fixed by: https://github.com/libusb/libusb/pull/1508

Handle size is 0 in usbi_reallocf() in libusbi.h

> When realloc is called with a size of 0, it is equivalent to calling free(ptr), and realloc returns NULL. That is not true: https://en.cppreference.com/w/c/memory/realloc > until C23: > if...

Handle size is 0 in usbi_reallocf() in libusbi.h

> makes libusb match FreeBSD, which is probably a good idea It is not. FreeBSD implementation of `reallocf` (e.g. [here](https://github.com/freebsd/freebsd-src/blob/main/lib/libc/stdlib/reallocf.c)) most likely depends on the behavior of FreeBSD's implementation of...