portfolYOU
portfolYOU copied to clipboard
Allow Hiding Skill's Percentage
This gives the possibility to the developer of deciding if the % is shown or not.
Hi, thanks for your fast response. Maybe I did not explain it very well. The idea of this PR is to let the user have the possibility of having the bar with a percentage but hiding the percentage label.
If your concern is more about preventing breaking the existing sites, I could just add a check in the new if, checking if the attr exists.
My bad, didn't understand it that way.
For the other approach you are proposing, I think it would be better if the showPercentage
is a site-level configuration in _config.yml
for consistency.
Hi, sorry for the late reply. I did not get the notification.
With your proposal, you cannot decide whether you want for some and not for others. There are different sections and with the solution, I propose you can do several things. With your proposal, it is either YES or NO.
I don't understand why we might need to hide the percentage label for some skills and not for others. This behavior seems inconsistent.
you can instead just do something like {% unless hidePercentage == true %}
so it doesnt break existing pages right? this way it will only hide if the variable is defined and set to true. if its not defined, nothing will change.
Edit: like this here.