Youssef Victor

--- #### Internal previews | 📄 File | 🔗 Preview link | |:--|:--| | [docs/core/testing/microsoft-testing-platform-extensions-diagnostics.md](https://github.com/dotnet/docs/blob/9c905849751db0b015781784494cb6fc0e2ea054/docs/core/testing/microsoft-testing-platform-extensions-diagnostics.md) | [Diagnostics extensions](https://review.learn.microsoft.com/en-us/dotnet/core/testing/microsoft-testing-platform-extensions-diagnostics?branch=pr-en-us-50346) |

Add examples to dotnet-gcdump doc

2

Following the pattern of https://raw.githubusercontent.com/dotnet/docs/master/docs/core/diagnostics/dotnet-counters.md we should have an Examples h3 section following each Options h3 section. _Originally posted by @tdykstra in https://github.com/dotnet/docs/pull/19697_ --- #### Document Details ⚠ *Do not...

Current implementation of analyzers relies on syntax when it really needs semantics. This is a bad practice and is very error prone. This PR modernizes few analyzer implementations to follow...

Related to https://github.com/dotnet/orleans/issues/9664, but doesn't fix it. ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/dotnet/orleans/pull/9665)

xunit.v3

1

## Description Fixes # (issue, if applicable) ## Checklist - [ ] Test cases added - [ ] Performance benchmarks added in case of performance changes - [ ] Release...

Usage of dotnet.config

1

Hi @Tapanila I noticed dotnet.config is used in this repo. FYI, if https://github.com/dotnet/sdk/pull/50673 gets merged, then updating to RC2 with that change will require moving away from dotnet.config to global.json....

Disallow test methods with out/ref parameters

1

Today, the following is allowed: ```csharp [TestMethod] [DataRow("Hello", "World")] public void TestMethod1(out string s, ref string s2) { s = ""; } ``` I think we should: 1. Fail at...

Investigate test case association feature and its support with MTP

15

https://learn.microsoft.com/en-us/azure/devops/test/associate-automated-test-with-test-case?view=azure-devops It looks like this feature may be working by setting a VSTest property on TestCase, which means it may not work with MTP. We need to investigate further.

[Style] Target-typed new in the codebase

7

We have excessive use of target-typed new, which (IMO) makes the code much harder to read in many cases where the type isn't apparent. I would consider switching the code...

Prefer passing specific services to constructor instead of `IServiceProvider`

3

We have multiple places where we pass `IServiceProvider` to constructors. Usually, it's better to make the dependencies very explicit (helps with testability and code clarity as to what exactly a...