Youssef Victor
Youssef Victor
Closing as it's low value and the exception is easily replaceable by user-defined exception type.
@Evangelink The reason I'm putting it in 3.10 is that a similar breaking change was taken already in VSTest in a minor release. https://www.nuget.org/packages/Microsoft.NET.Test.Sdk/17.14.0 is net8.0+ while https://www.nuget.org/packages/Microsoft.NET.Test.Sdk/17.13.0 is netcoreapp3.1+....
Moving to v4 then. We will then have to be careful not to update VSTest dependency to 17.14. 😕
I don't think `TestMethodIdentifierProperty.TypeName` should be nullable. For all cases that are potentially valid for testing, I think `FullName` is always going to be non-null. Do you have a specific...
`dynamic` should be treated as `System.Object`. For generics, it's more complicated. Unfortunately, we are in a position today where `TestMethodIdentifierProperty` isn't well standardized. And, that's all because VSTest history and...
Yes, it's used to control the display if VSTest's "hierarchy" property isn't sent. But the lack of a standardization is mostly non-issue (or let's say very very small issue) when...
Closing stale issue.
> How would the actual usage look like? I think we can assume that most users just use single CI and they don't way to specify it. How would inverse...
@nohwnd Yes we can start by not requiring to specify any specific CI system. So the attribute just requires `ConditionMode`. Later on, we can add extra constructor overloads (or properties)...
@nohwnd We keep collecting the test nodes in memory here: https://github.com/microsoft/testfx/blob/85128834dc5707bd3f92ddbeeb77bcc4f9fae300/src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxDataConsumer.cs#L42 Then only in `OnTestSessionFinishingAsync` we will start do something with them. https://github.com/microsoft/testfx/blob/85128834dc5707bd3f92ddbeeb77bcc4f9fae300/src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxDataConsumer.cs#L229-L232