ElasticUI icon indicating copy to clipboard operation
ElasticUI copied to clipboard

Published 20 hours ago • verified publisher icon YousefED

only run this.search() when a query is set

Open joshbedo opened this issue 10 years ago • 5 comments

joshbedo avatar Oct 15 '15 21:10 joshbedo

  1. Seems you've added some code changes in demo.html which weren't intential
  2. can't we move the null checks to a more centralized place, instead of adding 5+ of them all around?

Thanks,

YousefED avatar Oct 19 '15 07:10 YousefED

Cool i can make those changes. Everything else make sense? I'll create some method like isQuerySet to check the value.

joshbedo avatar Oct 19 '15 14:10 joshbedo

Just made changes let me know if everything looks alright.

joshbedo avatar Oct 19 '15 15:10 joshbedo

Hi, I didn't mean moving the null checks to a separate method. I meant can't we have 1 check further down / up in the call stack and thus centralize the logic?

YousefED avatar Oct 20 '15 07:10 YousefED

ahh okay, sorry i misunderstood.

joshbedo avatar Oct 20 '15 14:10 joshbedo