ElasticUI icon indicating copy to clipboard operation
ElasticUI copied to clipboard

allow variable ejs to be located somewhere other than the window object

Open markbirbeck opened this issue 10 years ago • 2 comments

I'm using browserify to create a single JS file, rather than using script tags. Unless I've missed some piece of trickery, I have to place the elastic.js object onto the window object in order to make it available to elasticui, like this:

require('elasticsearch/src/elasticsearch.angular');
window.ejs = require('elastic.js');
require('elasticui/dist/elasticui');

It feels kind of clunky, especially in Angular-land.

markbirbeck avatar Apr 09 '15 11:04 markbirbeck

Thanks. I think this can be easily fixed by making ejs a dependency in IndexController and FilterTool. If you're able to submit a pull request I can test it and update the project!

YousefED avatar Apr 09 '15 12:04 YousefED

Sure. I'll take a look when I get a minute.

On Thu, 9 Apr 2015 at 13:47 Yousef [email protected] wrote:

Thanks. I think this can be easily fixed by making ejs a dependency in IndexController and FilterTool. If you're able to submit a pull request I'll happily test it and update the project!

— Reply to this email directly or view it on GitHub https://github.com/YousefED/ElasticUI/issues/35#issuecomment-91220399.

markbirbeck avatar Apr 09 '15 14:04 markbirbeck