Julijan Nikolic

Results 45 comments of Julijan Nikolic

Skia vertical aligement: ``` switch (text.mVAlign) { case EVAlign::Top: y = r.T - ascender - descender; break; case EVAlign::Middle: y = r.MH() - descender + (textHeight / 2.0); break; case...

Other backends will need more work to fix this.

I forgot to fix the middle align. Here it is: ``` switch (text.mVAlign) { case EVAlign::Top: y = r.T - ascender - descender; break; case EVAlign::Middle: y = r.MH() -...

Indeed, this should be discussed. This is probably going to be breaking, so it will better to do it right. @AlexHarker It does make sense what you did, however, there...

It seems that you can oversample stbtt fonts in order to get better fonts at small sizes. Here is one commit that adds this (or similar thing) to NanoVG: https://github.com/memononen/nanovg/pull/278/commits/90d4a007c10c7e7d95ca31798a1c6daeec88e53e

This indeed seem to work: ![Annotation 2020-05-02 181936](https://user-images.githubusercontent.com/13148293/80869621-c91d8600-8ca1-11ea-96c4-750deb7f3ac9.png)

Here is more about oversampling: https://github.com/nothings/stb/tree/master/tests/oversample

Harfbuzz text placement could shine a light on how to set the text placement: ![typography](https://user-images.githubusercontent.com/13148293/80870342-1bf93c80-8ca6-11ea-8777-6832d97ee9c0.jpg)

@AlexHarker Sorry for the late reply! It's OK to have the implementation as it was for text positioning, but you can also add baseline positioning and maybe "topline" positioning that...

Thanks. It would be nice if you can add license type inside shader source, or make some list on readme.