extension icon indicating copy to clipboard operation
extension copied to clipboard

[Feature Request] Add support for embedded YouTube players

Open 2mustange opened this issue 2 months ago • 7 comments

Describe the bug Forcing Playback speed doesn't occur on embedded video

To Reproduce Steps to reproduce the behavior:

  1. Go to 'https://old.reddit.com/domain/youtube.com/'
  2. Click on any video
  3. Force Playback Speed doesn't occur and buttons missing

Expected behavior

  • Forced Playback speed should occur on embedded videos and/or should show playback speed buttons

Screenshots

  • None at this time

Desktop (please complete the following information):

  • OS: [Windows 10]
  • Browser [Firefox]
  • Version [144]

Additional context If this is intended, per how it was developed, then I would like to request the feature of this extension being used on embedded YT videos

2mustange avatar Nov 05 '25 00:11 2mustange

A summary of the changes CodeRabbit can apply:

  • Add isEmbedPage() in src/utils/utilities.ts, and update src/pages/embedded/index.ts to import it and include it in shouldEnableFeaturesFuncReturn() so /embed/ pages are recognized and player features (forced playback speed, speed buttons, volume, shortcuts, etc.) are enabled.

  • Update src/utils/utilities.ts to add an isEmbedPage() helper that detects "embed" in the URL, and modify src/pages/embedded/index.ts to exclude embed pages from feature enabling by adding isEmbedPage() to the shouldEnableFeatures check.

  • [ ] ✅ Create PR with these edits
  • [ ] 📋 Get copyable edits

coderabbitai[bot] avatar Nov 05 '25 00:11 coderabbitai[bot]

@2mustange When I click any of the videos in the link you attached it goes to that video on youtube in the current tab not an embedded video player. I didn't consider the extension running on embedded players. Can you provide a screen recording of what is happening ?

VampireChicken12 avatar Nov 05 '25 00:11 VampireChicken12

@2mustange When I click any of the videos in the link you attached it goes to that video on youtube in the current tab not an embedded video player. I didn't consider the extension running on embedded players. Can you provide a screen recording of what is happening ?

Here is a video using a "barebones" firefox profile so no config changes or any other add-ons minus ublock origin. You see me navigate to the site, verify my playback speed is 2x, and play the embedded video through its player. I manually adjust the playback speed through YT's embedded player settings. Based on your reply I guess this is by current design, so i am glad I am not missing anything.

https://github.com/user-attachments/assets/e7da9fd2-b439-40a7-b448-08044e375c24

2mustange avatar Nov 05 '25 01:11 2mustange

Thanks for the video, I can look into getting the extension working in the embedded video

VampireChicken12 avatar Nov 05 '25 01:11 VampireChicken12

I looked into adding support for YouTube embeds, and it seems like it’ll take a bit of work. Since embeds use /embed instead of /watch, a lot of the features would need changes because they’re currently built around the regular watch page. @2mustange

VampireChicken12 avatar Nov 05 '25 01:11 VampireChicken12

I looked into adding support for YouTube embeds, and it seems like it’ll take a bit of work. Since embeds use /embed instead of /watch, a lot of the features would need changes because they’re currently built around the regular watch page. @2mustange

Thanks for looking into it! No rush. Just wanted to put the idea out there

2mustange avatar Nov 05 '25 05:11 2mustange

I looked into adding support for YouTube embeds, and it seems like it’ll take a bit of work. Since embeds use /embed instead of /watch, a lot of the features would need changes because they’re currently built around the regular watch page. @2mustange

Thanks for looking into it! No rush. Just wanted to put the idea out there

You're welcome thank you for using the extension!

VampireChicken12 avatar Nov 05 '25 05:11 VampireChicken12