Cassiopeia icon indicating copy to clipboard operation
Cassiopeia copied to clipboard

issues about assign_lineage_groups() function

Open AmoriLi opened this issue 2 years ago • 0 comments

Thanks for developing such a useful tool for reconstructing phylogenetic tree. when looking into the source code of assigning lineage groups to each cells, I am not sure about if it is correct in several details. There are two main questions confusing me as follows:

https://github.com/YosefLab/Cassiopeia/blob/master/cassiopeia/preprocess/lineage_utils.py 1. Screen Shot 2022-11-23 at 12 01 02 AM in the last 3rd line, should it be 'prev_clust_size = piv_nolg.shape[0]' because we only need to assign lineage group to the undefined cells with number more than 'min_clust_size'. Is there something important I've missed or misunderstood?

Screen Shot 2022-11-23 at 12 09 28 AM Screen Shot 2022-11-23 at 12 11 21 AM

the above intBC set was used in iteratively assignment of lineage groups and the bottom one master_intBC was applied to calculate kinship_score. but these two intBC sets were actually not same because they were filtered via different criteria. so I am wondering if it is more efficient and accurate than using the same criteria to selecting intBC set and master_intBC?

Hope I have got the meaning of your code and looking forward to your reply~

AmoriLi avatar Nov 22 '22 16:11 AmoriLi