your_spotify icon indicating copy to clipboard operation
your_spotify copied to clipboard

Typo and code suggestion

Open jellebuitenhuis opened this issue 1 month ago • 2 comments

Hi, I have two suggestions for your codebase, one is a typo and the other one is for readability:

On line 70 there is a typo, it says being instead of begin: https://github.com/Yooooomi/your_spotify/blob/e3c4a0eca25c04e9639adf5c81aa6e6915af33b3/apps/client/src/scenes/Settings/Importer/FullPrivacy/FullPrivacy.tsx#L70

Also, on line 62 you do this:

      {files &&
        Array.from(Array(files.length).keys()).map(i => (
          <Text key={i} element="div">
            {files.item(i)?.name}
          </Text>
        ))}

You can simplify this to the following:

{files &&
  Array.from(files).map((file, index) => (
    <Text key={index} element="div">
      {file.name}
    </Text>
  ))
}

This also holds true for https://github.com/Yooooomi/your_spotify/blob/e3c4a0eca25c04e9639adf5c81aa6e6915af33b3/apps/client/src/scenes/Settings/Importer/Privacy/Privacy.tsx#L66

jellebuitenhuis avatar Nov 18 '25 08:11 jellebuitenhuis