Yohann
Yohann
## Review checklist for @YohannDudouit ### Conflict of interest - [x] I confirm that I have read the [JOSS conflict of interest (COI) policy](https://github.com/openjournals/joss/blob/master/COI.md) and that: I have no COIs...
I opened the issue https://github.com/jeremiah-corrado/fem_2d/issues/2 containing a number of observations and suggestions.
@jedbrown We may want to discuss specific points to see if they meet the JOSS criteria, in particular "Substantial scholarly effort", "Functionality", "Performance", "Functionality documentation", "A statement of need", and...
> The code looks good, and it will be good to have the option to get deterministic results for FA matrix assembly. > > I think we need to answer...
> > @pazner Here is the GPU trace, what do you think? > > It's a little hard to tell in this format. It seems like the problem was relatively...
I believe this has been fixed with https://github.com/mfem/mfem/pull/3056 .
We can talk more about it during the PR meeting, but this would require a refactor to take into account the diagonal policy. Here is a temporary fix: https://github.com/mfem/mfem/pull/3127
Please fix Travis :) I think we don't want the style that Travis is suggesting.
@tzanio Can you look into the style suggestion of Travis and confirm we want it?
@dylan-copeland I fixed the warnings.