mvcforum icon indicating copy to clipboard operation
mvcforum copied to clipboard

Like, dislike, favourite buttons don't save to the DB

Open BaiMangal opened this issue 8 years ago • 4 comments

Like, dislike, favourite buttons don't save to the DB image

BaiMangal avatar Mar 22 '18 14:03 BaiMangal

Hmm I must have broken something. Will have a look tomorrow.

YodasMyDad avatar Mar 22 '18 15:03 YodasMyDad

I am debugging it and it records in the DB but doesn’t retrieve it for some reason. If I find out will email you.

From: Lee [mailto:[email protected]] Sent: Thursday 22 March 2018 15:19 To: YodasMyDad/mvcforum [email protected] Cc: BaiMangal [email protected]; Author [email protected] Subject: Re: [YodasMyDad/mvcforum] Like, dislike, favourite buttons don't save to the DB (#231)

Hmm I must have broken something. Will have a look tomorrow.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/YodasMyDad/mvcforum/issues/231#issuecomment-375344678, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGVIsXtyEw88PV1JCa86XNHhDC_lbs_Vks5tg8D7gaJpZM4S3JQo.

BaiMangal avatar Mar 22 '18 15:03 BaiMangal

The fixes required to solve this issue are very small.

  1. In VoteService.cs the votes were not being grouped by post then by topic. Instead They were being grouped by post then by post again.
  2. In TopicController.cs the starting post was never added to the list of posts that the votes should be retrieved for, therefore they were not.

Modified Files.zip

P,s. I have never done a merge request before so I don't know how to add this fix to the repo @YodasMyDad

RelativeForce avatar Aug 29 '18 11:08 RelativeForce

Thanks

boc2010 avatar Apr 06 '19 04:04 boc2010