yoast-components icon indicating copy to clipboard operation
yoast-components copied to clipboard

Help center button too tall in IE11

Open afercia opened this issue 7 years ago • 1 comments

In IE11 the Help Center button looks taller than in other browsers:

screenshot 96

HelpCenterButton extends YoastButton which uses a CSS hack to fix an IE11 bug with min-height and flexbox.

https://github.com/Yoast/yoast-components/blob/214ee6f37fcb9bbc8fa9ce2ca5b5c5463c1894a1/composites/Plugin/Shared/components/YoastButton.js#L58-L65

So its min-height is hardcoded to 48 pixels because this value was the design requirement. If we want to change the min-height, then also the hack for IE11 needs to be adjusted accordingly.

afercia avatar Sep 28 '18 14:09 afercia

See the branch 746-help-center-button-height-ie11

afercia avatar Sep 28 '18 14:09 afercia