yoast-components icon indicating copy to clipboard operation
yoast-components copied to clipboard

Snippet preview: color and width props rendered as HTML attributes (invalid HTML)

Open afercia opened this issue 7 years ago • 1 comments

Noticed a couple props are actually rendered in the HTML as (invalid) attributes:

<div class="SnippetPreview__MobileContainer-jipmEz iYVbUi" width="640" ...

<div color="#545454" class="SnippetPreview__MobileDescription-iHXWQq ...

<div color="#545454" class="SnippetPreview__MobileDescriptionOverflowContainer-OwMUS ...

Note: the MobileDescriptionOverflowContainer is going to be removed in #542

Note 2: is there any way to automate checking for props that render invalid attributes? /Cc @atimmer @Xyfi

afercia avatar May 25 '18 14:05 afercia

Re-tested: as far as I see, color is gone and width is still there.

afercia avatar Aug 06 '18 08:08 afercia