Review and improve usage of target="_blank"

Open afercia opened this issue 8 years ago • 1 comments

Noticed a few places where we're using target="_blank" and the message to inform users the link is going to open a new browser tab/window is missing or hardcoded:

1 Onboarding WIzard failure message: to make this message appear, just set "Offline" in the Chrome console network panel and click on the "Next" button:

screen shot 2017-11-06 at 12 15 41

in this case, the message is missing.

2 Dashboard widget:

screen shot 2017-11-06 at 12 28 18

on the first 2 links, there's a hardcoded string ( Opens in a new browser tab ) which is not translatable
on the link in the footer, the message is missing

Worth noting WordPress has started using icons to give also a visual indication of links with target="_blank". See for example the "nearby events" widget. This is not a standard yet across WordPress, but maybe worth considering to use it.

screen shot 2017-11-06 at 12 27 29

Nov 06 '17 11:11 afercia

There's now also the Cornerstone checkbox, its label has a link with target="_blank". See #439 and https://github.com/Yoast/wordpress-seo/issues/7288

Mar 27 '18 10:03 afercia