yoast-acf-analysis
yoast-acf-analysis copied to clipboard
Yoast
Ensure no errors on CPTs without Yoast SEO metabox
I'm having an issue with the testing code being inside the plugin, but I understand that the total approach needs to be revised in order to change this.
As we don't want to ship the tests or any non-build files in the actual plugin, we would be referencing code that does not exist.
I absolutely agree with that. This was kind of ok while it was just one simple thing. But as this grows we'll need to get this out at some point.
I think the question here and now is if we get this out and clean up later or put this on hold until we have #111 sorted out.
Let's add this functionality first and remove the testing from the plugin afterwards. Could you resolve the conflicts?
I think it would be better the other way around. Because I'd need to fix the conflicts here, merge this, which then in turn will cause conflicts in #117 plus the need to rework everything in this PR anyway. Sounds like a lot of wasted effort.
Is there any reason you see with #117 why it can't be merged before?
@kraftner the only thing that was blocking #117 was a the bit of code that mocked the WordPress global & add_action functionality.
I have done a CR on that PR and provided a better way to resolve that problem.
As #117 has been merged, this can be implemented. Could you resolve the merge conflict? Would be nice to also add some comment at each entry what data it is adding and why.
Could you also merge develop into this branch, to make sure all tests and travis are passing on it as well?