wordpress-seo icon indicating copy to clipboard operation
wordpress-seo copied to clipboard

901 add unit tests for cli command handler

Open thijsoo opened this issue 1 month ago • 1 comments

Context

  • We want to add unit tests.

Summary

This PR can be summarized in the following changelog entry:

  • Adds tests for the commands + handlers.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • N/A

Relevant test scenarios

  • [ ] Changes should be tested with the browser console open
  • [ ] Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • [ ] Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • [ ] Changes should be tested on different browsers
  • [ ] Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • [X] QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • [ ] This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • [ ] I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • [x] I have tested this code to the best of my abilities.
  • [ ] During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • [ ] I have added unit tests to verify the code works as intended.
  • [ ] If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • [ ] I have written this PR in accordance with my team's definition of done.
  • [ ] I have checked that the base branch is correctly set.
  • [ ] I have ran grunt build:images and commited the results, if my PR introduces new images or SVGs.

Innovation

  • [ ] No innovation project is applicable for this PR.
  • [ ] This PR falls under an innovation project. I have attached the innovation label.
  • [ ] I have added my hours to the WBSO document.

Fixes #

thijsoo avatar Dec 08 '25 12:12 thijsoo

Pull Request Test Coverage Report for Build 52c3d55f3a8313365a692d198d63739230bb9c19

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-4.9%) to 46.045%

Totals Coverage Status
Change from base Build de2c551191d9e8b57ebe98f4bd99a877f82f2006: -4.9%
Covered Lines: 17596
Relevant Lines: 38215

💛 - Coveralls

coveralls avatar Dec 08 '25 13:12 coveralls