Announce the addition of the Google docs add on to Free & Premium #4603
Context
- Announce the addition of the Google docs add on to Free & Premium.
Summary
This PR can be summarized in the following changelog entry:
- Announces the addition of the Google docs add on to Free & Premium.
Relevant technical choices:
- GoogleDocsAddonUpsell component added to implement this. It Content required to be wrapped in Modal to be displayed correctly. IsPremium at some pages we can take only from wpseoIntroductions object so it's used.
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Check that Yoast SEO Google Docs Add-On - incl. in Premium upsell modal is displayed in for Free.
- Deactivate Yoast Premium plugin if it's active.
- Open Yoast Test plugin and click Reset First time configuration progress.
- Deactivate and the free plugin.
- Open any sql editor or use
wp db querywp-cli command and remove _yoast_wpseo_introductions meta_key from wp_usermeta table:DELETE FROM `wp_usermeta` WHERE `meta_key` = '_yoast_wpseo_introductions' - Activate the free plugin.
- Make sure that Yoast SEO Google Docs Add-On - incl. in Premium upsell modal is displayed and fit the design:
- Click on Unlock with Yoast SEO Premium button and make sure that url is opened in new tab (the pages should be created and active before tests).
Check that Yoast SEO Google Docs Add-On - incl. in Premium upsell modal is displayed in for Premium.
- Deactivate Yoast Premium plugin if it's active.
- Open Yoast Test plugin and click Reset First time configuration progress.
- Open plugins page.
- Open any sql editor or use
wp db querywp-cli command and remove _yoast_wpseo_introductions meta_key from wp_usermeta table:DELETE FROM `wp_usermeta` WHERE `meta_key` = '_yoast_wpseo_introductions' - Activate the premium plugin.
- Make sure that Yoast SEO Google Docs Add-On - incl. in Premium upsell modal is not displayed and fit the design:
- Click on Get started for free button and make sure that url is opened in new tab (the pages should be created and active before tests).
Relevant test scenarios
- [x] Changes should be tested with the browser console open
- [ ] Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
- [ ] Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
- [ ] Changes should be tested on different browsers
- [ ] Changes should be tested on multisite
Test instructions for QA when the code is in the RC
- [x] QA should use the same steps as above.
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
- Should not impact other places.
UI changes
- [x] This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.
Other environments
- [ ] This PR also affects Shopify. I have added a changelog entry starting with
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.
Documentation
- [x] I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.
Quality assurance
- [x] I have tested this code to the best of my abilities.
- [x] During testing, I had activated all plugins that Yoast SEO provides integrations for.
- [ ] I have added unit tests to verify the code works as intended.
- [ ] If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
- [x] I have written this PR in accordance with my team's definition of done.
- [x] I have checked that the base branch is correctly set.
Innovation
- [ ] No innovation project is applicable for this PR.
- [ ] This PR falls under an innovation project. I have attached the
innovationlabel. - [ ] I have added my hours to the WBSO document.
Fixes #4603
Pull Request Test Coverage Report for Build f7e11f5e7b03ab02365894213e6f578f3781e89a
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 3 of 28 (10.71%) changed or added relevant lines in 4 files are covered.
- 1 unchanged line in 1 file lost coverage.
- Overall coverage decreased (-0.02%) to 53.652%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| packages/js/src/introductions/initialize.js | 0 | 1 | 0.0% |
| packages/js/src/shared-admin/components/google-docs-addon-upsell.js | 3 | 5 | 60.0% |
| packages/js/src/introductions/components/content.js | 0 | 10 | 0.0% |
| src/introductions/application/google-docs-addon-upsell.php | 0 | 12 | 0.0% |
| <!-- | Total: | 3 | 28 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| packages/js/src/introductions/initialize.js | 1 | 0.0% |
| <!-- | Total: | 1 |
| Totals | |
|---|---|
| Change from base Build 3010e3277d95433295cd9d14a28c13715abc6a66: | -0.02% |
| Covered Lines: | 30346 |
| Relevant Lines: | 57579 |
💛 - Coveralls
@mykola the Learn more -> link is visible in the modal, but I don't see it in the design. Was it something decided later on?
CR ✅ AT ✅
A bit late but here are the links @mykola
Upsell UTM for free is https://yoa.st/gdocs-free Upsell UTM for premium is https://yoa.st/gdocs-premium