wordpress-seo icon indicating copy to clipboard operation
wordpress-seo copied to clipboard

Flushing of unused group `orphaned_counts`

Open kkmuffme opened this issue 7 months ago • 4 comments

  • [x] I've read and understood the contribution guidelines.
  • [x] I've searched for any related issues and avoided creating a duplicate issue.

Please give us a description of what happened

To Reproduce

https://github.com/Yoast/wordpress-seo/blob/trunk/src/builders/indexable-link-builder.php#L576 \wp_cache_flush_group( 'orphaned_counts' );

This group is never used anywhere. Calling flush on it just adds unnecessary load on the cache master. This code should be removed.

kkmuffme avatar May 22 '25 00:05 kkmuffme

Thank you @kkmuffme for your suggestion, indeed we should not be flushing that group there. I'm moving the task to our board to be picked up as soon as our priorities allow.

Internal note: 👇

So, let's remove the wp_cache_flush_group() and possibly add an action as per this.

leonidasmi avatar May 26 '25 11:05 leonidasmi

Please inform the customer of conversation # 1263858 when this conversation has been closed.

rmarcano avatar Jun 06 '25 15:06 rmarcano

Hi any news about this ? Will it be prioritized soon ?

Best regards,

samuelmichaud avatar Jun 12 '25 09:06 samuelmichaud

Hi @samuelmichaud We're currently picking up its implementation.

leonidasmi avatar Jun 13 '25 08:06 leonidasmi