wordpress-seo icon indicating copy to clipboard operation
wordpress-seo copied to clipboard

Remove the translation loading.

Open thijsoo opened this issue 8 months ago • 1 comments

Context

  • Since 6.7 we don't need to add our own translation domain loading.

Summary

This PR can be summarized in the following changelog entry:

  • Removes unneeded load_plugin_textdomain call.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Smoke test our plugin in another language than English and do the same for a multisite install.

Relevant test scenarios

  • [ ] Changes should be tested with the browser console open
  • [ ] Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • [ ] Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • [ ] Changes should be tested on different browsers
  • [ ] Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • [X] QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • [ ] This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • [ ] This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • [ ] I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • [X] I have tested this code to the best of my abilities.
  • [ ] During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • [ ] I have added unit tests to verify the code works as intended.
  • [ ] If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • [ ] I have written this PR in accordance with my team's definition of done.
  • [ ] I have checked that the base branch is correctly set.

Innovation

  • [ ] No innovation project is applicable for this PR.
  • [ ] This PR falls under an innovation project. I have attached the innovation label.
  • [ ] I have added my hours to the WBSO document.

Fixes #

thijsoo avatar May 08 '25 07:05 thijsoo

Pull Request Test Coverage Report for Build 8ad612e0d07e81871206f56a097e212b74325549

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1718 unchanged lines in 46 files lost coverage.
  • Overall coverage increased (+0.9%) to 53.67%

Files with Coverage Reduction New Missed Lines %
src/introductions/application/introductions-collector.php 1 96.77%
inc/class-my-yoast-api-request.php 1 97.06%
admin/views/class-yoast-feature-toggles.php 1 95.95%
src/introductions/application/ai-fix-assessments-upsell.php 2 58.33%
src/services/health-check/page-comments-check.php 2 81.82%
src/services/health-check/postname-permalink-check.php 2 81.82%
src/services/health-check/default-tagline-check.php 2 81.82%
src/services/health-check/links-table-check.php 2 83.33%
src/editors/framework/site/base-site-information.php 2 14.29%
src/introductions/infrastructure/introductions-seen-repository.php 3 90.32%
<!-- Total: 1718
Totals Coverage Status
Change from base Build c122b65f10dc870041aa32063f370fb2a203577e: 0.9%
Covered Lines: 30868
Relevant Lines: 58205

💛 - Coveralls

coveralls avatar May 08 '25 08:05 coveralls