wordpress-seo icon indicating copy to clipboard operation
wordpress-seo copied to clipboard

283 add keyword difficulty and intent to semrush modal with table in tailwind design

Open vraja-pro opened this issue 1 year ago • 1 comments

Context

Summary

This PR can be summarized in the following changelog entry:

  • Adds the semrush integration package.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Switch to the related-kephrase-suggestions package: cd packages/related-kephrase-suggestions
  • Run:
yarn install
yarn build
yarn storybook
Difficulty bullet

Check there are 6 different variants for the bullets based on the score and each on has a tootip message on hover with the following description. You can change the score in the control in the storybook and that will change the first bullet:

  • Very easy
    • Dark green (#009F81)
    • Range 0-14
    • Tooltip description: "Your chance to start ranking new pages."
  • Easy
    • Light green (#59DDAA)
    • Range 15-29
    • Tooltip description: "You will need quality content focused on the keyword’s intent."
  • Possible
    • Light green (#FDC23C)
    • Range 30-49
    • Tooltip description: "You will need well-structured and unique content."
  • Difficult
    • Light green (#FF8C43)
    • Range 50-69
    • Tooltip description: "You will need lots of ref. domains and optimized content."
  • Hard
    • Light green (#FF4953)
    • Range 70-84
    • Tooltip description: "You will need lots of high-quality ref. domains and optimized content."
  • Very Hard
    • Light green (#D1002F)
    • Range 85-100
    • Tooltip description: "It will take a lot of on-page SEO, link building, and content promotion efforts."
Intent Bade
  • Check there are 4 badges in the story book.
  • Check each badge color and background matches the design.
  • Check the tooltip text matches the design.
  • Use screen reader and check it can read the tooltip.
Difficulty table
  • Check there are 6 difficulty bullets in the story book.
  • Change the number in the story book, the first bullet should change.
  • Change to a single digit number and check it is align to the bullet.
  • Check each bullet color and background matches the design.
  • Check the tooltip text matches the design.
  • Use screen reader and check it can read the tooltip.
Trend graph
  • Check you can the graph in the story book.
  • Remove some of the data items and check you get an error message.
Keyphrases Table
  • Check there is a table with keyphrases, trend graph, intent, difficulty bullets and buttons.
  • Check there is a loading table story that matches the design.
  • Remove the premium prop and check the button column is gone. Check there is a story for that.
Country Selector
  • Check there is a label over the country field "Show results for:".
  • Check there is select field with a list of countries.
  • Check there is a button with a label "Change country".
  • Check it accept the following props:
    • country code
    • active country code
    • onChage
    • onSelect

Relevant test scenarios

  • [X] Changes should be tested with the browser console open
  • [ ] Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • [ ] Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • [ ] Changes should be tested on different browsers
  • [ ] Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • [X] QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • [ ] This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • [ ] This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • [ ] I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • [X] I have tested this code to the best of my abilities.
  • [ ] During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • [ ] I have added unit tests to verify the code works as intended.
  • [ ] If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • [ ] I have written this PR in accordance with my team's definition of done.
  • [ ] I have checked that the base branch is correctly set.

Innovation

  • [X] No innovation project is applicable for this PR.
  • [ ] This PR falls under an innovation project. I have attached the innovation label.
  • [ ] I have added my hours to the WBSO document.

Fixes Add keyword difficulty and intent to Semrush modal with table in Tailwind design

vraja-pro avatar Oct 10 '24 14:10 vraja-pro

Pull Request Test Coverage Report for Build 9e49a03280b8ac69af61e1ca237336e42de5df33

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 54.65%

Totals Coverage Status
Change from base Build fefa3a700f5152ccfc13e686df18a597af42d9cf: 0.0%
Covered Lines: 29700
Relevant Lines: 54648

💛 - Coveralls

coveralls avatar Oct 14 '24 07:10 coveralls

Tested all the columns, data-types, colors, tool-tips, design, responsiveness, browser compatibility.

hardikgohil7988 avatar Nov 08 '24 11:11 hardikgohil7988