Remove conditional and rename dashboard to general page.

[thijsoo]

Context

• We want to remove the conditional for the new dashboard page.

Summary

This PR can be summarized in the following changelog entry:

• Removes the conditional for the new dashboard page.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

• Make sure you do not have define( 'YOAST_SEO_NEW_DASHBOARD_UI', true ); in your project.
• Go to the dashboard and make sure you see the new dashboard.
• Make sure you do not see the old dashboard anywhere.
• Follow the test instructions in https://github.com/Yoast/wordpress-seo/pull/21661 to test for regressions.

Relevant test scenarios

• [ ] Changes should be tested with the browser console open
• [ ] Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• [ ] Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• [ ] Changes should be tested on different browsers
• [ ] Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• [X] QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

• [ ] This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

• [ ] This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• [ ] I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• [X] I have tested this code to the best of my abilities.
• [ ] During testing, I had activated all plugins that Yoast SEO provides integrations for.
• [ ] I have added unit tests to verify the code works as intended.
• [ ] If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• [ ] I have written this PR in accordance with my team's definition of done.
• [ ] I have checked that the base branch is correctly set.

Innovation

• [X] No innovation project is applicable for this PR.
• [ ] This PR falls under an innovation project. I have attached the innovation label.
• [ ] I have added my hours to the WBSO document.

Fixes #

[coveralls]

Pull Request Test Coverage Report for Build 23a72bf1994dab30060181382d0556bd26d909a7

Details

• 14 of 35 (40.0%) changed or added relevant lines in 17 files are covered.
• 538 unchanged lines in 3 files lost coverage.
• Overall coverage increased (+0.002%) to 54.571%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
admin/class-admin.php	0	1	0.0%
admin/views/tabs/tool/import-seo.php	0	1	0.0%
packages/js/src/general/hooks/use-select-general-page.js	0	1	0.0%
packages/js/src/general/initialize.js	0	1	0.0%
src/integrations/admin/first-time-configuration-integration.php	0	1	0.0%
src/integrations/admin/installation-success-integration.php	2	3	66.67%
src/integrations/admin/old-configuration-integration.php	0	1	0.0%
admin/class-config.php	0	2	0.0%
packages/js/src/general/app.js	0	2	0.0%
packages/js/src/general/routes/alert-center.js	0	5	0.0%
<!--	Total:	14	35

Files with Coverage Reduction	New Missed Lines	%
admin/class-config.php	1	0.0%
admin/views/tabs/tool/import-seo.php	2	0.0%
src/generated/container.php	535	0.39%
<!--	Total:	538

Totals
Change from base Build 8a4aceaf168b36d80a31b458f7c1a87587e5bbbf:	0.002%
Covered Lines:	29672
Relevant Lines:	54642

---

💛 - Coveralls

[pls78]

CR: ✅

[pls78]

CR: ✅

[hardikgohil7988]

Tested new dashbard (General page) without feature flag in single site and multisite. Tested all FTC scenarios in single site and multisite.