Fix tab focus for ai optimize toast element
Context
Summary
This PR can be summarized in the following changelog entry:
- Fixes a bug where the AI Optimize toast notification would not be accessible for keyboard and screenreader users.
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Relevant test scenarios
- [ ] Changes should be tested with the browser console open
- [ ] Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
- [ ] Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
- [ ] Changes should be tested on different browsers
- [ ] Changes should be tested on multisite
Test instructions for QA when the code is in the RC
- [ ] QA should use the same steps as above.
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
- [ ] This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.
Other environments
- [ ] This PR also affects Shopify. I have added a changelog entry starting with
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.
Documentation
- [ ] I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.
Quality assurance
- [ ] I have tested this code to the best of my abilities.
- [ ] During testing, I had activated all plugins that Yoast SEO provides integrations for.
- [ ] I have added unit tests to verify the code works as intended.
- [ ] If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
- [ ] I have written this PR in accordance with my team's definition of done.
- [ ] I have checked that the base branch is correctly set.
Innovation
- [ ] No innovation project is applicable for this PR.
- [ ] This PR falls under an innovation project. I have attached the
innovationlabel. - [ ] I have added my hours to the WBSO document.
Fixes #
@Jordi-PV Please be aware that following packages have been abandoned and are not actively maintained anymore:
| Package name | Path |
|---|---|
| @yoast/babel-preset | packages/babel-preset |
| @yoast/components | packages/components |
| @yoast/e2e-tests | packages/e2e-tests |
| @yoast/helpers | packages/helpers |
| @yoast/jest-preset | packages/jest-preset |
| @yoast/style-guide | packages/style-guide |
Please consider using the other packages instead.
Pull Request Test Coverage Report for Build 26bee99b9f7b80ebab79aed0993ba90c6eb24a4b
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall first build on fix-tab-focus-for-ai-optimize-toast-element at 26.839%
| Totals | |
|---|---|
| Change from base Build 1584e5a2b41465c3e61e992fd324fb4563c702b5: | 26.8% |
| Covered Lines: | 3725 |
| Relevant Lines: | 12761 |
💛 - Coveralls
A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch.
@Jordi-PV Please be aware that following packages have been abandoned and are not actively maintained anymore:
| Package name | Path |
|---|---|
| @yoast/babel-preset | packages/babel-preset |
| @yoast/components | packages/components |
| @yoast/e2e-tests | packages/e2e-tests |
| @yoast/helpers | packages/helpers |
| @yoast/jest-preset | packages/jest-preset |
| @yoast/style-guide | packages/style-guide |
Please consider using the other packages instead.
A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch.