wordpress-seo icon indicating copy to clipboard operation
wordpress-seo copied to clipboard

Add-tooltip-to-UI-library

Open Jordi-PV opened this issue 1 year ago • 1 comments

Context

  • To add a new tootip component in the Yoast UI library that can be used to create a better user experience.

Summary

This PR can be summarized in the following changelog entry:

  • Adds a tooltip element to the Yoast UI library.

Relevant technical choices:

  • The tooltip is created with the use of tailwind/css framework.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Git checkout to this branch 974-add-tooltip-to-ui-library
  • Install dependencies with the command yarn install
  • Run Storybook for local development yarn storybook or yarn workspace @yoast/ui-library storybook
  • A new Storybook tab will open on your browser running on your local server
  • Navigate to the Elements < Tooltip

Relevant test scenarios

  • [X] Changes should be tested with the browser console open
  • [ ] Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • [ ] Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • [X] Changes should be tested on different browsers
  • [ ] Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • [X] QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • [ ] This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • [ ] This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • [X] I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • [X] I have tested this code to the best of my abilities.
  • [ ] During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • [ ] I have added unit tests to verify the code works as intended.
  • [ ] If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • [X] I have written this PR in accordance with my team's definition of done.
  • [X] I have checked that the base branch is correctly set.

Innovation

  • [X] No innovation project is applicable for this PR.
  • [ ] This PR falls under an innovation project. I have attached the innovation label.
  • [ ] I have added my hours to the WBSO document.

Fixes #

Jordi-PV avatar Feb 02 '24 15:02 Jordi-PV

Pull Request Test Coverage Report for Build 22cd5dfec543d4ed5d068be6cb79fb2b55d41c30

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 84 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.002%) to 56.07%

Files with Coverage Reduction New Missed Lines %
packages/js/src/shared-admin/components/premium-upsell-card.js 1 0.0%
packages/js/src/structured-data-blocks/how-to/legacy/11.4.js 4 0.0%
packages/js/src/settings/components/formik-page-select-field.js 14 0.0%
packages/js/src/settings/components/formik-autocomplete-field.js 15 0.0%
packages/social-metadata-forms/src/SocialMetadataPreviewForm.js 16 0.0%
packages/js/src/structured-data-blocks/how-to/components/HowToStep.js 34 0.0%
<!-- Total: 84
Totals Coverage Status
Change from base Build b59b2c3048b1bd951811780a3c67b9a4f43d85c6: -0.002%
Covered Lines: 13487
Relevant Lines: 23649

💛 - Coveralls

coveralls avatar Feb 02 '24 15:02 coveralls