wordpress-seo icon indicating copy to clipboard operation
wordpress-seo copied to clipboard

Published 20 hours ago • verified publisher icon Yoast

MariaDB incompatible query

Open skyycode opened this issue 1 year ago • 2 comments

https://github.com/Yoast/wordpress-seo/blob/a2903680a2a3e58802fb2a398f96ba7d6a2b89a4/inc/sitemaps/class-post-type-sitemap-provider.php#L120

The version check may pass for MariaDB, but the query inside the 'if' statement is not compatible with MariaDB

skyycode avatar Dec 12 '23 17:12 skyycode

Hi @skyycode

Thanks for using the Yoast SEO plugin and reporting the issue you noticed with MariaDB.

I have forwarded this internally to the appropriate development team, and we will keep you posted on this soon.

josevarghese avatar Dec 13 '23 08:12 josevarghese

Looking deeper into the usage of db_version(), the ROW_NUMBER() window function is supported only since MariaDB 10.2: this means that versions 10.0 and 10.1 may fail. So besides changing the method we may need to check whether MariaDB is used and adjust the check accordingly

enricobattocchi avatar Dec 27 '23 18:12 enricobattocchi