wordpress-seo icon indicating copy to clipboard operation
wordpress-seo copied to clipboard

PC-638 Add options to tracking

Open thijsoo opened this issue 2 years ago • 0 comments

Context

  • We added new options to change the robots txt output, but we did not add them to our tracking.

Summary

This PR can be summarized in the following changelog entry:

  • Adds two options to the tracking data.

Relevant technical choices:

  • None.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • edit /admin/class-admin.php, and at the end of the constructor (should be line 115) add the following lines:
		if ( filter_input( INPUT_GET, 'action' ) === 'test' ) {
			$collector = new WPSEO_Collector();
			$collector->add_collection( new WPSEO_Tracking_Settings_Data() );
			echo '<pre>';
			print_r( $collector->collect() );
			echo '</pre>';
		}
		die;
  • test the tracking of the setting: visit http://basic.wordpress.test/wp-admin/admin.php?page=wpseo_dashboard&action=test and see that among the lines in the array there is: [deny_search_crawling] => 1 [deny_wp_json_crawling] => 1 or 0 as value depending on how the setting is set in your config.

Relevant test scenarios

  • [ ] Changes should be tested with the browser console open
  • [ ] Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • [ ] Changes should be tested on different editors (Block/Classic/Elementor/other)
  • [ ] Changes should be tested on different browsers
  • [ ] Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • [X] QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • [ ] This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • [ ] This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • [ ] I have written documentation for this change.

Quality assurance

  • [ ] I have tested this code to the best of my abilities
  • [ ] I have added unit tests to verify the code works as intended
  • [ ] If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • [ ] I have written this PR in accordance with my team's definition of done.

Fixes #

thijsoo avatar Sep 21 '22 07:09 thijsoo