Process Taxonomy type before CPT
Context
- Title rewritings
Summary
This fixes https://github.com/Yoast/wordpress-seo/issues/9539
Taxonomy can be assigned to multiple post types. This allows to use CPT variables like %%pt_singular%% and %%pt_plural%% in taxonomy rewritings. This was able to last in version 13. Sadly it is not able to change by any filter.
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Relevant test scenarios
- [ ] Changes should be tested with the browser console open
- [ ] Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
- [ ] Changes should be tested on different editors (Block/Classic/Elementor/other)
- [ ] Changes should be tested on different browsers
- [ ] Changes should be tested on multisite
Test instructions for QA when the code is in the RC
- [ ] QA should use the same steps as above.
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
- [ ] This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.
Other environments
- [ ] This PR also affects Shopify. I have added a changelog entry starting with
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.
Documentation
- [ ] I have written documentation for this change.
Quality assurance
- [x] I have tested this code to the best of my abilities
- [ ] I have added unit tests to verify the code works as intended
- [ ] If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
- [ ] I have written this PR in accordance with my team's definition of done.
Fixes # https://github.com/Yoast/wordpress-seo/issues/9539
Thank you for the contribution @radeno.
Could you share some step-by-step Test Instructions so we can dive into this thoroughly?
Here we go. @leonidasmi
Test case
- create new CPT
- create new TAX
- link them together:
'taxonomies' => [$CPT_NAME],andregister_taxonomy($TAX_NAME, $CPT_NAME, $args); - define new rewrite rule as:
$CTP_NAME / $TAX_NAME - define SEO Title for TAX as
%%pt_plural%% %%sep%% %%term_title%%
Before change: No CPT plural name in the final Title After change: CPT plural name provided in the final Title
More in my comment with two screenshots provided https://github.com/Yoast/wordpress-seo/issues/9539#issuecomment-731742523